Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] - Tracing issues #8103

Closed
dalexandrov opened this issue Dec 5, 2023 · 3 comments · Fixed by #8105
Closed

[4.x] - Tracing issues #8103

dalexandrov opened this issue Dec 5, 2023 · 3 comments · Fixed by #8105
Assignees
Labels
4.x Version 4.x bug Something isn't working tracing
Projects
Milestone

Comments

@dalexandrov
Copy link
Contributor

dalexandrov commented Dec 5, 2023

Environment Details

  • Helidon Version: 4.0.1
  • Helidon SE
  • JDK version: 21
  • OS: OSX

The following Helidon SE app created:
https://helidon.io/starter/4.0.1?step=9&app-type=custom&tracing=true

When testing with Jaeger:

  • tracing.enabled not working. With tracing.enabled=false, still SEVERE: Failed to export spans. The request could not be executed. Full error message: Failed to connect to localhost/[0:0:0:0:0:0:0:1]:14250
  • attempting to rename the "HTTP Request" span doesn't seem to have an effect
  • disabling content-write span doesn't seem to have an effect
@dalexandrov dalexandrov added bug Something isn't working tracing 4.x Version 4.x labels Dec 5, 2023
@github-actions github-actions bot added this to Triage in Backlog Dec 5, 2023
@m0mus m0mus added this to the 4.0.2 milestone Dec 5, 2023
@tjquinno tjquinno self-assigned this Dec 5, 2023
@tjquinno tjquinno moved this from Triage to Sprint Scope in Backlog Dec 5, 2023
@tjquinno
Copy link
Member

tjquinno commented Dec 5, 2023

@dalexandrov In the failing attempts to rename the span and disable the content-write span, are the changes done programmatically or using config? (Need a reproducer - I am trying to construct one that mimics the user experience but I need to know how they are trying to do this.)

In my quick experiment so far disabling tracing in config works for me to suppress the error message if Jaeger is not running.

@tjquinno
Copy link
Member

tjquinno commented Dec 5, 2023

Update:

Using this config

tracing:
  service: helidon-tracing-service
  enabled: true
  components:
    web-server:
      spans:
        - name: "HTTP Request"
          new-name: "HTTP %1$s %2$s"
          logs:
            - name: "content-write"
              enabled: false

I find that:

  1. There is no error message if I set tracing.enabled to false.
  2. The HTTP Request span is correctly renamed to HTTP <method> <path>
  3. Disabling context-write does not seem to work.

Please provide a reproducer for the first two items.

I will continue looking into the third.


With Jaeger shut down and several curl http://localhost:8080/simple-greet accesses:

java  -jar target/myproject.jar     
2023.12.05 17:13:36.892 Jaeger Tracer is explicitly disabled.
2023.12.05 17:13:37.033 Helidon SE 4.0.1 features: [Config, Encoding, Media, Observe, Tracing, WebServer]
2023.12.05 17:13:37.044 [0x0c9759e6] http://0.0.0.0:8080 bound for socket '@default'
2023.12.05 17:13:37.058 Started all channels in 22 milliseconds. 664 milliseconds since JVM startup. Java 21+35-2513
WEB server is up! http://localhost:8080/simple-greet

With Jaeger up:
Tracing issue 8103 Jaeger screen capture

@dalexandrov
Copy link
Contributor Author

I can confirm point 1 and 2 are working ok with this config:

tracing:
  enabled: true
  service: helidon-se-1
  protocol: http
  port: 14250
  path: /api/traces
  tags:
    env: development
  sampler-type: "const"
  sampler-param: 1
  log-spans: true
  propagation: b3
  components:
    web-server:
      spans:
        - name: "HTTP Request"
          new-name: "HTTP %1$s %2$s %3$s"
          logs:
            - name: "content-write"
              enabled: false

Backlog automation moved this from Sprint Scope to Closed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x bug Something isn't working tracing
Projects
Backlog
  
Closed
3 participants