Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate attribute and animal entries #6

Closed
sunsided opened this issue Feb 5, 2023 · 1 comment
Closed

Duplicate attribute and animal entries #6

sunsided opened this issue Feb 5, 2023 · 1 comment

Comments

@sunsided
Copy link

sunsided commented Feb 5, 2023

The adjectives list contains duplicates of the words skinny, short, long, cool, hot and tangy.
The animal list contains duplicates of the word tiger, mammoth and raccoon.
The word swift is used both as an adjective and animal name.

It seems like the wordlists test should contain no duplicate entries should have caught this but it checks only against the original list lengths rather than the actual wordcount tally keys:

describe('wordlists', () => {
it('should contain no duplicate entries', () => {
const wordlist = adjectives.concat(colors).concat(animals);
const wordcount = wordlist.reduce((tally, word) => {
if(!tally[word]) {
tally[word] = 1;
} else {
tally[word] = tally[word] + 1;
}
return tally;
}, {});
expect(Object.keys(wordlist).length).to.equal(256 * 3);
})
})

Other (derived?) implementations such as angry-purple-tiger-rs and erl_angry_purple_tiger have the same issue.

@madninja
Copy link
Member

madninja commented Feb 5, 2023

Indeed they do. Unfortunately this can not be fixed since it would break existing names for folks. i.e.if we fix the list your hotspot would suddenly change names.

@madninja madninja closed this as completed Feb 5, 2023
@madninja madninja closed this as not planned Won't fix, can't repro, duplicate, stale Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants