Restarting LSP after Cargo add kills the LSP

[Alacho2]

Summary

Adding a crate to a project requires a restart of an LSP for the new changes to the be picked up. However, when the restart lsp command is issued, the stream is closed (says the log) and no auto-completion of suggestions are being made while typing (or when manually accessing). Exiting helix and starting it again causes everything to be picked up correctly. The status bar shows "Request timed out".

My project is Rust-based.

Reproduction Steps

I tried this:

1. hx . in a rust folder
2. In a second terminal, issue some kind of cargo add, for example for rand.
3. Try accessing something inside of Rand, no suggestions are made, other suggestions work.
4. Restart the lsp from inside helix, see the metadata being generated in the status bar
5. Try getting the auto complete or suggestions to work, and nothing happens

I expected this to happen:
For helix to pick up a cargo change and correctly apply that change

Instead, this happened:
The LSP just dies until helix is restarted entirely.

Helix log

~/.cache/helix/helix.log

2024-04-29T14:45:12.489 helix_lsp::transport [ERROR] Tried sending response into a closed channel (id=Num(847)), original request likely timed out
2024-04-29T14:45:12.643 helix_lsp::transport [ERROR] Tried sending response into a closed channel (id=Num(849)), original request likely timed out
2024-04-29T14:45:12.816 helix_lsp::transport [ERROR] Tried sending response into a closed channel (id=Num(850)), original request likely timed out
2024-04-29T14:45:12.971 helix_lsp::transport [ERROR] Tried sending response into a closed channel (id=Num(852)), original request likely timed out
2024-04-29T14:45:13.196 helix_lsp::transport [ERROR] Tried sending response into a closed channel (id=Num(853)), original request likely timed out
2024-04-29T14:45:19.887 helix_lsp::transport [ERROR] Tried sending response into a closed channel (id=Num(870)), original request likely timed out
2024-04-29T14:58:46.359 helix_lsp::transport [ERROR] rust-analyzer <- ServerError(-32801): content modified
2024-04-29T15:23:56.981 helix_lsp::transport [ERROR] rust-analyzer <- InvalidParams: code action without data
2024-04-29T15:40:59.173 helix_view::document [ERROR] Formatter error: error: expected type, found `{`
 --> <stdin>:2:38
  |
2 | fn generate_random_client_token() -> {
  |                                      ^ expected type


2024-04-29T15:46:52.625 helix_lsp::transport [ERROR] rust-analyzer err: <- StreamClosed
2024-04-29T15:47:18.622 helix_lsp::client [WARN] language server failed to terminate gracefully - server closed the stream
2024-04-29T15:47:18.637 helix_lsp::transport [ERROR] rust-analyzer err: <- StreamClosed

Platform

Macos

Terminal Emulator

Kitty

Installation Method

brew

Helix Version

24.3

[pascalkuthe]

Which commit exactly did you use (24.3 release or a more recent commit from master)? There was recently a regression and subsequent fix for restarting on master.

Definitly can't reproduce

[Alacho2]

Thanks for the prompt response. hx -V is showing 2cadec0. I just ran a brew update/upgrade as well, just to be sure.

[pascalkuthe]

So it's the last release. That's odd Haven't seen any issues related to restarting yet that would have been noticed. You could try building from master and make sure RA is up to date (latest nightly build).

Your log file doesn't contain anything useful. The only thing I see there is that the old server doesn't shutdown properly. Maybe that's interfering with the statup of the new server (since we don't wait for the old waver to stop before we start the new server).