Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add ADL language support #10029

Merged
merged 3 commits into from Apr 8, 2024
Merged

feat: Add ADL language support #10029

merged 3 commits into from Apr 8, 2024

Conversation

millergarym
Copy link
Contributor

Created a tree-sitter grammar for ADL to get syntax highlighting (and other goodness) in Helix.

@the-mikedavis the-mikedavis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. A-language-support Area: Support for programming/text languages labels Mar 28, 2024
@millergarym
Copy link
Contributor Author

@the-mikedavis thanks for the review. A couple of the other captures have been updated to match the documentation.

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 2, 2024
the-mikedavis
the-mikedavis reviewed Apr 2, 2024
View reviewed changes
runtime/queries/adl/highlights.scm Outdated Show resolved Hide resolved
runtime/queries/adl/highlights.scm Outdated Show resolved Hide resolved
runtime/queries/adl/highlights.scm Outdated Show resolved Hide resolved
runtime/queries/adl/highlights.scm Outdated Show resolved Hide resolved
@the-mikedavis the-mikedavis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from a maintainer. labels Apr 2, 2024
@millergarym
Copy link
Contributor Author

@the-mikedavis thanks for the review.
I found an issue with the grammar, which has been fixed.
All your capture suggestions have been included, note: I've used comment.block.documentation instead of just comment.
imo info might have been nicer, only because it would show up under more themes.

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 3, 2024
@millergarym
Copy link
Contributor Author

@the-mikedavis thx, what the next step getting a second approval?

@pascalkuthe pascalkuthe merged commit 0da809c into helix-editor:master Apr 8, 2024
6 checks passed
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
@millergarym @postsolar
feat: Add ADL language support (helix-editor#10029)
dd4cdf4 
* feat: Add ADL language support

* removed error match & change captures to match https://docs.helix-editor.com/master/themes.html\#syntax-highlighting

* fixes to grammar, highlight changes based on PR and grammar fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@pascalkuthe pascalkuthe pascalkuthe approved these changes

Assignees
No one assigned
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@millergarym @the-mikedavis @pascalkuthe