fix mouse right click selection #10067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
added
the
S-waiting-on-review
the-mikedavis
added
S-waiting-on-author
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
the-mikedavis
previously approved these changes
Mar 31, 2024
pascalkuthe
reviewed
Apr 1, 2024
|
I think this was somewhat deliberate, we're editing breakpoints which are only supported with column offsets (start of line) in many debuggers |
i changed it so that when clicking on the margin it edits the breakpoint, and when clicking inside the document it selects the character. |
the-mikedavis
added
S-waiting-on-review
pascalkuthe
approved these changes
Apr 8, 2024
the-mikedavis
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #10066