Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle partial failure when sending textDocument/didSave #10168

Merged
merged 1 commit into from Apr 6, 2024

Conversation

the-mikedavis
Copy link
Member

One language server being uninitialized or exited should not prevent the other(s) from being notified of didSave.

Fixes #10162

One language server being uninitialized or exited should not prevent
the other(s) from being notified of didSave.
@the-mikedavis the-mikedavis added C-bug Category: This is a bug A-language-server Area: Language server client S-waiting-on-review Status: Awaiting review from a maintainer. labels Apr 5, 2024
@the-mikedavis the-mikedavis self-assigned this Apr 5, 2024
@pascalkuthe
Copy link
Member

multi lsp was really a huge change still finding bugs with that after all this time

@archseer archseer merged commit 3f2de21 into master Apr 6, 2024
6 checks passed
@archseer archseer deleted the handle-partial-lsp-did-save-failure branch April 6, 2024 04:38
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-server Area: Language server client C-bug Category: This is a bug S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not sending textDocument/didSave notifications to all LSPs
3 participants