Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Typst 0.11 #10321

Merged
merged 6 commits into from Apr 16, 2024
Merged

Support Typst 0.11 #10321

merged 6 commits into from Apr 16, 2024

Conversation

Idobenhamo
Copy link
Contributor

Update the tree sitter to support Typst 0.11 and changed the lsp to Tinymist

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages labels Apr 9, 2024
@the-mikedavis the-mikedavis self-requested a review April 9, 2024 14:27
@keirlawson
Copy link
Contributor

Why switch language server?

@Idobenhamo
Copy link
Contributor Author

It has more active development and more features...

@keirlawson
Copy link
Contributor

Tinymist looks to have existed for about a month, it might be a good idea to "wait and see" for a little while longer before concluding it is better maintained

@Idobenhamo
Copy link
Contributor Author

So what about adding them both?

@Idobenhamo
Copy link
Contributor Author

@the-mikedavis Is that ok? Just added both of the lsp's.

@the-mikedavis
Copy link
Member

Yep having both should be fine, whichever one you have installed will be used

@pascalkuthe pascalkuthe merged commit 68765f5 into helix-editor:master Apr 16, 2024
6 checks passed
shaleh pushed a commit to shaleh/helix that referenced this pull request Apr 16, 2024
* Update the tree sitter to support Typst 0.11 and changed the lsp to Tinymist

* Fixed

* Added typst-lsp & tinymist

---------

Co-authored-by: Idobenhamo <idobenhamo@users.noreply.github.com>
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
* Update the tree sitter to support Typst 0.11 and changed the lsp to Tinymist

* Fixed

* Added typst-lsp & tinymist

---------

Co-authored-by: Idobenhamo <idobenhamo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants