Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger template: allow missing or empty completion list #10332

Merged

Conversation

fengalin
Copy link
Contributor

It can be convenient to define project specific debugger templates, some of which might not necessitate prompting the user to define completion.

This commit makes completion optional for debugger templates and starts the dap immediately if undefined or empty.

It can be convenient to define project specific debugger templates, some of
which might not necessitate prompting the user to define completion.

This commit makes completion optional for debugger templates and starts the
dap immediately if undefined or empty.
@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. A-debug-adapter Area: Debug adapter client labels Apr 11, 2024
@pascalkuthe pascalkuthe merged commit f86f350 into helix-editor:master May 6, 2024
6 checks passed
@fengalin fengalin deleted the debug-tmpl-opt-completion branch May 6, 2024 15:50
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
…or#10332)

It can be convenient to define project specific debugger templates, some of
which might not necessitate prompting the user to define completion.

This commit makes completion optional for debugger templates and starts the
dap immediately if undefined or empty.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-debug-adapter Area: Debug adapter client S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants