Implement read command #10447
Merged
Implement read command #10447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's customary to give the original author Co-authored-by attribution when reusing work: https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors |
|
I can do that. No problem. |
shaleh
force-pushed
the
implement-read-command
branch
from
979b9c1
to
c265117
Compare
|
For the coauthor part, git/github is expecting the attribution in a To fix the docs CI you can run |
the-mikedavis
added
S-waiting-on-author
shaleh
commented
Apr 16, 2024
shaleh
commented
Apr 16, 2024
shaleh
commented
Apr 16, 2024
shaleh
commented
Apr 16, 2024
|
Thank you for taking a look @the-mikedavis. All of the items identified have been resolved. |
|
the test associated with this command is failing on windows in ci |
pascalkuthe
reviewed
Apr 16, 2024
Resurrects helix-editor#3966. This is 100% @idursun's work. Using read_to_string from helix-editor#7431. Co-authored-by: ibrahim@dursun.cc
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Co-authored-by: Ibrahim Dursun <ibrahim@dursun.cc>
shaleh
force-pushed
the
implement-read-command
branch
from
0a7e86a
to
a8c2d48
Compare
the-mikedavis
added
S-waiting-on-review
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
the-mikedavis
approved these changes
Apr 17, 2024
pascalkuthe
approved these changes
Apr 17, 2024
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 20, 2024
Co-authored-by: Michael Davis <mcarsondavis@gmail.com> Co-authored-by: Ibrahim Dursun <ibrahim@dursun.cc>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resurrects #3966. This is 100% @idursun's work. Using
read_to_stringfrom #7431.closes #3796