Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for registerCapability for formatting and rangeFormatting #10589

Closed
adrian-budau opened this issue Apr 24, 2024 · 3 comments
Closed

Support for registerCapability for formatting and rangeFormatting #10589

adrian-budau opened this issue Apr 24, 2024 · 3 comments
Labels
C-enhancement Category: Improvements R-duplicate Duplicated issue: please refer to the linked issue

Comments

@adrian-budau
Copy link

Rudimentary support is quite easy to implement (ignoring document filters) and would fix most of the language servers based on vscode-languageserver-node that seem to only support formatting and rangeFormatting only as dynamic capability, without helix advertising support for it.

I've implemented this level of support on a personal branch and I'd be happy to open a PR but I'm waiting on a different PR to land in lsp-types #280

@adrian-budau adrian-budau added the C-enhancement Category: Improvements label Apr 24, 2024
@kirawi
Copy link
Member

kirawi commented Apr 24, 2024

The range formatting part is a dupe of #3209

@kirawi
Copy link
Member

kirawi commented Apr 24, 2024

registerCapability is a dupe of #5141

@kirawi kirawi closed this as not planned Won't fix, can't repro, duplicate, stale Apr 24, 2024
@kirawi kirawi added the R-duplicate Duplicated issue: please refer to the linked issue label Apr 24, 2024
@pascalkuthe
Copy link
Member

Also I am pretty sure that I used language servers baswd on vscode-languahe-server bide where formatting was working so I am not sure that is generally true.

I would prefer to not add dynamic capability registration. It's not really useful to us and a spec compliant server should allow static registration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Improvements R-duplicate Duplicated issue: please refer to the linked issue
Projects
None yet
Development

No branches or pull requests

3 participants