Remove ' and add ⟨⟩ in lean autopairs #10688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
approved these changes
May 5, 2024
pascalkuthe
added
the
S-waiting-on-review
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an auto-pairs section to the lean configuration with ⟨⟩ and without ''
Rationale: ⟨⟩ is very commonly used for pattern matching and essentially always used in a pair, and ' is also very commonly used for denoting "prime" almost never used in a pair. If only using one ' the pairing isn't an issue, but when trying to type two, the pairing creates ''' instead, and the same issue is present when trying to type four, etc.
There were issues with 3 byte characters for pairs but they were fixed: #3964 and #3946.
Sorry if there are any issues, I'm new to this.