Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find window color collision avoidance #10857

Closed
wyager opened this issue May 31, 2024 · 2 comments
Closed

Find window color collision avoidance #10857

wyager opened this issue May 31, 2024 · 2 comments
Labels
C-enhancement Category: Improvements

Comments

@wyager
Copy link

wyager commented May 31, 2024

Sometimes when I search, the search highlight color conflicts with the text color.

Would it be possible to check if a character's syntax-highlighted color equals the search highlight color, and if so, change the character's color to something else?
Screenshot 2024-05-30 at 8 08 25 PM

@wyager wyager added the C-enhancement Category: Improvements label May 31, 2024
@kirawi
Copy link
Member

kirawi commented May 31, 2024

It's up to the themes to choose what they highlight.

@wyager
Copy link
Author

wyager commented Jun 1, 2024

This is sort of orthogonal to the theme, is it not? Regardless of theme color choice, it probably shouldn't be possible to have foreground and background be the same color.

@helix-editor helix-editor locked and limited conversation to collaborators Jun 6, 2024
@pascalkuthe pascalkuthe converted this issue into discussion #10894 Jun 6, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

2 participants