Incorrect syntax highlighting with CRLF line endings

[chtenb]

Summary

It seems that some languages exhibit incorrect syntax highlighting when looking at a file with crlf line endings. I've seen this with nushell and koka, two languages I use personally.

I originally created an issue in the koka treesitter repo, but the current hypothesis seems to be that it is a generic Helix problem:
mtoohey31/tree-sitter-koka#3

Reproduction Steps

I tried this:

1. hx
2. Set language to koka :set-language koka
3. Set line endings to CRLF :line-ending crlf
4. Insert the following snippet

// Generate True with probability k/n
fun gen-bool(k: int, n: int) : random bool
  rnd-int32(0, n) < k

I expected this to happen:

Instead, this happened:

Helix log

No response

Platform

Windows

Terminal Emulator

wezterm 20240520-135708-b8f94c47

Installation Method

source

Helix Version

reproducible with several recent versions, including origin/master

[the-mikedavis]

Looks like 7ae49de (#6417) will fix this, I can't reproduce after that commit.