feat(ui): file encoding in statusline #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display file encoding in statusline if the encoding isn't UTF-8.
archseer
reviewed
Dec 25, 2021
helix-term/Cargo.toml
Outdated
| @@ -50,6 +50,8 @@ pulldown-cmark = { version = "0.8", default-features = false } | |||
| # file type detection | |||
| content_inspector = "0.2.4" | |||
|
|
|||
| encoding_rs = "0.8" | |||
There was a problem hiding this comment.
Doesn't helix-view/helix-core re-export encoding already? We shouldn't have to import this twice
There was a problem hiding this comment.
helix-view used it but didn't re-export it. I re-exported it from helix-core and import it from there in helix-view and helix-term.
From there it can be imported by other mods that rely on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display file encoding in statusline if the encoding isn't UTF-8.
I assume this will be configurable in the future with the rest of the statusline but for now this seems like a reasonable step in between, hopefully with reasonable default.