add tree-sitter-git-config #1426
Conversation
the-mikedavis
force-pushed
the
md-tree-sitter-git-config
branch
3 times, most recently
from
efc0ebb
to
dcac147
Compare
Wow \o/ |
| name = "git-config" | ||
| scope = "source.gitconfig" | ||
| roots = [] | ||
| file-types = [".gitmodules", ".gitconfig"] |
There was a problem hiding this comment.
Is this a good idea? It could be .git/config as well. Not sure how we can do it here.
@archseer I think we might have to add support to check for the path as well.
There was a problem hiding this comment.
Hmm yeah I think if file-types could be a regex or a glob that'd work? We'd want to detect git-config for a few files where the containing directory/ies are important
There was a problem hiding this comment.
For git it's actually a little more complicated. Git repositories don't have to be called .git. That is just the default for working trees. There many other possible variations. e.g bare repositories, submodules and git with multiple working trees (see git-worktree).
.git/modules/helix-syntax/languages/tree-sitter-c/config for example is probably a git config file in your helix working tree.
The best way afaik to detect git config files is to check for other items in the same directory. objects and refs for example.
I'm pretty sure other file types will be in a similar situation.
bat seems to have this figured out. Perhaps would be worth looking to see how they do it?
There was a problem hiding this comment.
I am thinking that's better done as plugin or some sort of check then. But right now the simplest would be regex on full path.
|
@the-mikedavis Do you think it's good to merge this now? I think the leftover can be done separately, maybe can just leave a todo comment saying to improve that. |
|
sounds good to me! let me just push a commit with the todo comment 馃憤 |
the-mikedavis
force-pushed
the
md-tree-sitter-git-config
branch
from
b33b8b3
to
e11606b
Compare
* add tree-sitter-git-config * add todo comment for improving filetype check
Since I spend so much time looking at
.gitmodulesI thought it should have some highlighting 馃槃Luckily git uses this config syntax for virtually all config, so this grammar applies to things like
~/.gitconfigas well.I think this is a good grammar to start asking questions about expanding the
file-typesconfig inlanguages.toml. Ideally this grammar would apply for.git/config,~/.config/git/config, and otherconfigfiles under a git directory (for example:.git/modules/helix-syntax/languages/tree-sitter-git-config/config). I'm fine leaving off changes to language detection in this PR but it's something to think about.Playground for the grammar: https://the-mikedavis.github.io/tree-sitter-git-config/