Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prioritize gutter diagnostics #2827

Closed
sbromberger opened this issue Jun 19, 2022 · 1 comment · Fixed by #2835
Closed

prioritize gutter diagnostics #2827

sbromberger opened this issue Jun 19, 2022 · 1 comment · Fixed by #2835
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements

Comments

@sbromberger
Copy link
Contributor

Describe your feature request

Right now if there are multiple issues of different severity on a given line, it is possible that a less-severe (i.e., warning) gutter icon overrides a more severe (i.e., error) icon. It would be nice if the highest-severity issue could be displayed. Here's an example:
error

On line 11, there are two errors and one warning (the suggestion to borrow). The gutter icon briefly flashed a red dot, but then the yellow dot overwrote the red dot. It'd be better if the red dot persisted because that is probably something that should take a higher precedence.

@sbromberger sbromberger added the C-enhancement Category: Improvements label Jun 19, 2022
@kirawi kirawi added the A-helix-term Area: Helix term improvements label Jun 19, 2022
@the-mikedavis
Copy link
Member

the-mikedavis commented Jun 20, 2022

I agree these should be prioritized by severity 👍

The relevant source for this is in helix_view::gutter::diagnostic if you'd like to give it a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants