languages: Fix ruby rakefile and gemfile file type #2875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
languages.toml
Outdated
| @@ -446,7 +446,7 @@ source = { git = "https://github.com/cstrahan/tree-sitter-nix", rev = "6b71a810c | |||
| name = "ruby" | |||
| scope = "source.ruby" | |||
| injection-regex = "ruby" | |||
| file-types = ["rb", "rake", "rakefile", "irb", "gemfile", "gemspec"] | |||
| file-types = ["rb", "rake", "Rakefile", "irb", "Gemfile", "gemspec"] | |||
There was a problem hiding this comment.
I've seen some foo.rakefile files in the wild. I'm not sure it's technically valid of if it's just allowed by case-insensitive file systems. Let's have both rakefile and Rakefile for anyone using the lowercase version (might as well do the same for the gemfile too)
There was a problem hiding this comment.
@the-mikedavis
Thank you for your review.
I changed to both file type is available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found default listed ruby file type (
rakefileandgemfile) does not match Rakefile and Gemfile, so fix them.