Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let extend-line respect range direction #3046

Merged
merged 5 commits into from
Aug 29, 2022
Merged

let extend-line respect range direction #3046

merged 5 commits into from
Aug 29, 2022

Conversation

QiBaobin
Copy link
Contributor

No description provided.

@the-mikedavis
Copy link
Member

I think this would be good as a new command but it shouldn't change the existing x binding. We could rename the old implementation extend_line_below and use that in the default binding for x

@QiBaobin
Copy link
Contributor Author

I think this would be good as a new command but it shouldn't change the existing x binding. We could rename the old implementation extend_line_below and use that in the default binding for x

Good point, did the change based on your suggestion. I keep the new command unbind as I couldn't find a good key for it, I think we can bind it in the config for now.

book/src/keymap.md Outdated Show resolved Hide resolved
QiBaobin and others added 2 commits August 10, 2022 12:33
Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it out again and doesn't seemed to notice any special differences so I guess should be good. Thanks.

But since this is a breaking change (if user currently specify this themselves), I think we may need to put it in the changelog or so. So I guess will wait for @the-mikedavis to merge this so he knows to write a changelog.

Do we have any procedure to tag like pull request for changelog?

@archseer archseer merged commit 411c5e4 into helix-editor:master Aug 29, 2022
@the-mikedavis
Copy link
Member

Ah sorry, idk how I missed the ping 😅

I'll note the breaking change in the changelog 👍. I'm not sure there's anything we can do to tag them to make it easier - I look at the compare links which don't have labels. A new label could still be useful though since I do watch the PRs.

AlexanderBrevig pushed a commit to AlexanderBrevig/helix that referenced this pull request Aug 29, 2022
* let extend-line respect range direction

* fix extend above logic

* keep `x` existing binding

* Update book/src/keymap.md

Co-authored-by: Ivan Tham <pickfire@riseup.net>

Co-authored-by: Ivan Tham <pickfire@riseup.net>
@the-mikedavis the-mikedavis added the R-breaking-change This PR is a breaking change for some behavior label Aug 29, 2022
AlexanderBrevig pushed a commit to AlexanderBrevig/helix that referenced this pull request Aug 29, 2022
* let extend-line respect range direction

* fix extend above logic

* keep `x` existing binding

* Update book/src/keymap.md

Co-authored-by: Ivan Tham <pickfire@riseup.net>

Co-authored-by: Ivan Tham <pickfire@riseup.net>
thomasskk pushed a commit to thomasskk/helix that referenced this pull request Sep 9, 2022
* let extend-line respect range direction

* fix extend above logic

* keep `x` existing binding

* Update book/src/keymap.md

Co-authored-by: Ivan Tham <pickfire@riseup.net>

Co-authored-by: Ivan Tham <pickfire@riseup.net>
jdrst pushed a commit to jdrst/helix that referenced this pull request Sep 13, 2022
* let extend-line respect range direction

* fix extend above logic

* keep `x` existing binding

* Update book/src/keymap.md

Co-authored-by: Ivan Tham <pickfire@riseup.net>

Co-authored-by: Ivan Tham <pickfire@riseup.net>
herkhinah pushed a commit to herkhinah/helix that referenced this pull request Dec 11, 2022
* let extend-line respect range direction

* fix extend above logic

* keep `x` existing binding

* Update book/src/keymap.md

Co-authored-by: Ivan Tham <pickfire@riseup.net>

Co-authored-by: Ivan Tham <pickfire@riseup.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R-breaking-change This PR is a breaking change for some behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extend_line_above ignores count
5 participants