Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show diagnostics when anywhere on its line #3078

Closed
diktomat opened this issue Jul 15, 2022 · 5 comments · Fixed by #6417
Closed

Show diagnostics when anywhere on its line #3078

diktomat opened this issue Jul 15, 2022 · 5 comments · Fixed by #6417
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements

Comments

@diktomat
Copy link
Contributor

diktomat commented Jul 15, 2022

Currently Helix only shows LSP diagnostics when the cursor is on the specific characters the diagnostic is for. Sometimes this can be hard to find, sometimes the characters are not even underlined, like in my demo below with a one character diagnostic. Helix should (maybe optionally) show diagnostics if the cursor is anywhere on the line, not just on the specific characters.

asciicast

@diktomat diktomat added the C-enhancement Category: Improvements label Jul 15, 2022
@sudormrfbin
Copy link
Member

sudormrfbin commented Jul 15, 2022

For finding the exact position of the error you can use ]d and [d.

@archseer
Copy link
Member

We used to default to anywhere on the line but what if there's multiple diagnostics on a single line?

@diktomat
Copy link
Contributor Author

We used to default to anywhere on the line but what if there's multiple diagnostics on a single line?

This can already happen, like Rust has error and hint often for the same part of the same line. They are just shown one message per line:
image

@Yevgnen
Copy link
Contributor

Yevgnen commented Sep 4, 2022

That's what I'm missing in lsp-ui of Emacs.

@erasin
Copy link
Contributor

erasin commented Feb 22, 2023

#6059

@kirawi kirawi added the A-helix-term Area: Helix term improvements label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants