Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gutters padding automatic #3163

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

pickfire
Copy link
Contributor

@pickfire pickfire commented Jul 23, 2022

Remove padding gutter type, and automatically add 1 padding if gutters is
non-empty.

Fix #3111

cc @kchibisov hopefully this solves your issue

Sad to see a breaking change but it should be fine given that we haven't do a release yet

@@ -332,8 +332,6 @@ pub enum GutterType {
Diagnostics,
/// Show line numbers
LineNumbers,
/// Show one blank space
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the element because it's still useful if you want to add padding between diagnostics and line number for example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I add it back then it no longer fix the issue, I think probably a separate fix is needed, but for now I think it is fine.

Remove padding gutter type, and automatically add 1 padding if gutters is
non-empty.
@kchibisov
Copy link

cc @kchibisov hopefully this solves your issue

It doesn't solve my issue, the padding is still colored for me.

Like the problem that it's not like padding isn't there, but that it's using gutters color, but before it was using a backround color.

picture

@pickfire
Copy link
Contributor Author

pickfire commented Jul 24, 2022

Like the problem that it's not like padding isn't there, but that it's using gutters color, but before it was using a backround color.

Yes, for the extra "padding" now it uses gutter color which is correct (in case you pad it between line-numbers it won't look weird), but the 1-width padding we added by default does not use that gutter style, so it should be fine.
Screenshot_20220724_103703

@archseer
Copy link
Member

You forgot to remove the padding component from the default: https://github.com/helix-editor/helix/blob/dfc31e74af1b96d9097496f1faa38710ecd30580/helix-view/src/editor.rs#L476=

@archseer archseer merged commit 2f98047 into helix-editor:master Jul 26, 2022
@archseer
Copy link
Member

Fixed in 255c173

@pickfire pickfire deleted the auto-gutter-padding branch July 27, 2022 03:49
thomasskk pushed a commit to thomasskk/helix that referenced this pull request Sep 9, 2022
Remove padding gutter type, and automatically add 1 padding if gutters is
non-empty.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Padding is now using gutter's color
3 participants