Improved file-picker configuration documentation #3422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added statement that git related file-picker configurations only work in a git repo.
| @@ -119,6 +119,7 @@ the default file-picker configuration below are IgnoreOptions: whether hidden | |||
| files and files listed within ignore files are ignored by (not visible in) the | |||
| helix file picker and global search. There is also one other key, `max-depth` | |||
| available, which is not defined by default. | |||
| All git related options are only enabled in a git repository. | |||
There was a problem hiding this comment.
Tiny spacing nit: can you add a blank line between these two paragraphs? They're rendered as one paragraph without the separating blank line
the-mikedavis
approved these changes
Aug 14, 2022
the-mikedavis
changed the title
|
Thank you! |
AlexanderBrevig
pushed a commit
to AlexanderBrevig/helix
that referenced
this pull request
Aug 29, 2022
thomasskk
pushed a commit
to thomasskk/helix
that referenced
this pull request
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added statement that git related file-picker configurations only work in
a git repo.
Closes #3415
Can somebody confirm that actually all git related file-picker configurations options are only enabled in a git repo and not only the git-ignore option?