Allow less than and greater than in macros #3556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
approved these changes
Aug 30, 2022
There was a problem hiding this comment.
Makes sense 👍. These were removed with #2369 but we do end up needing lt and gt because the key-sequence DSL uses <*> for multi-character keys and key-combinations. With this change, a macro that uses </> for indents is recorded as <lt>/<gt>.
|
Great work as always @A-Walrus! 🎉 |
thomasskk
pushed a commit
to thomasskk/helix
that referenced
this pull request
Sep 9, 2022
* Allow less than and greater than in macros * Fix failing test
jdrst
pushed a commit
to jdrst/helix
that referenced
this pull request
Sep 13, 2022
* Allow less than and greater than in macros * Fix failing test
herkhinah
pushed a commit
to herkhinah/helix
that referenced
this pull request
Dec 11, 2022
* Allow less than and greater than in macros * Fix failing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3538