Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonokai #3595

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Sonokai #3595

merged 2 commits into from
Aug 29, 2022

Conversation

p4ymak
Copy link
Contributor

@p4ymak p4ymak commented Aug 29, 2022

Added Sublime Text theme Sonokai.

@AlexanderBrevig
Copy link
Contributor

AlexanderBrevig commented Aug 29, 2022

Hi! Looking good!
Can you please add

"ui.cursorline.primary" = { bg = "something" }

To the theme so that #3234 lints OK and that I can see the cursorline I expect to see when using the theme?

Of course, replace something to whatever you think is nice (I liked bg1 and bg2).

image
Like this for instance:
image

Copy link
Contributor

@AlexanderBrevig AlexanderBrevig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add key; "ui.cursorline.primary" ref comment.

Copy link
Contributor

@AlexanderBrevig AlexanderBrevig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@p4ymak
Copy link
Contributor Author

p4ymak commented Aug 29, 2022

added "ui.cursorline.primary"

@the-mikedavis the-mikedavis merged commit ab67788 into helix-editor:master Aug 29, 2022
@the-mikedavis
Copy link
Member

Could you add a screenshot of this to the themes wiki? https://github.com/helix-editor/helix/wiki/Themes

@p4ymak
Copy link
Contributor Author

p4ymak commented Aug 29, 2022

Could you add a screenshot of this to the themes wiki? https://github.com/helix-editor/helix/wiki/Themes

Done!

thomasskk pushed a commit to thomasskk/helix that referenced this pull request Sep 9, 2022
Co-authored-by: Roman Chumak <p4ymak@yandex.ru>
jdrst pushed a commit to jdrst/helix that referenced this pull request Sep 13, 2022
Co-authored-by: Roman Chumak <p4ymak@yandex.ru>
herkhinah pushed a commit to herkhinah/helix that referenced this pull request Dec 11, 2022
Co-authored-by: Roman Chumak <p4ymak@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants