Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global search should search opened documents #4207

Closed
pathwave opened this issue Oct 11, 2022 · 2 comments · Fixed by #5652
Closed

Global search should search opened documents #4207

pathwave opened this issue Oct 11, 2022 · 2 comments · Fixed by #5652
Labels
C-enhancement Category: Improvements

Comments

@pathwave
Copy link

Currently global search only read files from disk, this creates two problems:
Unsaved content is not search-able and the resulting search result can end up on wrong line (and selection) because of unsaved content in-between. I think it would be better if it searched throught opened documents and excluded those opened documents from the disk search.

@pathwave pathwave added the C-enhancement Category: Improvements label Oct 11, 2022
@pppKin
Copy link
Contributor

pppKin commented Oct 18, 2022

Good call. I think this would be easier to implement after (the much anticipated) #3110 is merged.

@pathwave
Copy link
Author

I implemented it for #4381, so it just needs a copy/paste ish after im done with #4381.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants