Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved diagnostics picker formatting #4243

Open
CptPotato opened this issue Oct 13, 2022 · 2 comments
Open

Improved diagnostics picker formatting #4243

CptPotato opened this issue Oct 13, 2022 · 2 comments
Labels
C-enhancement Category: Improvements

Comments

@CptPotato
Copy link
Contributor

The current layout for the diagnostics picker is not that great.
The file path takes up a lot of space (for example \c\U\a\s\h\h\s\c\lsp.rs) and most of the diagnostic text is cut off as a result:

screenshot

image

My suggestion is to nest the diagnostics for each file like this for example:

image

This reduces the redundant file paths and allows to show more of the actual diagnostic message.

However, I'm not sure how well this integrates into the picker, since it expects a flat list where each entry can be selected from what I can tell. It's also not 100% clear to me how searching should be implemented using this layout.

@CptPotato CptPotato added the C-enhancement Category: Improvements label Oct 13, 2022
@the-mikedavis
Copy link
Member

Maybe we could re-use the tree display from #2377 for this?

@pascalkuthe
Copy link
Member

pascalkuthe commented Jan 30, 2023

Something like this would also be nice for global search, see #5730. I think it makes sense to track all of these feature requests in this issue because any solution to this problem should be generic and not just applied to a single picker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

3 participants