Allow "" to act as a pair for mim

[lukepighetti]

If you have the text ("yoo█oo") with your cursor placed in the middle and use mim, it will select inside the parens instead of inside the quotes. Expected result is to act inside the quotes

helix 22.08.1 (66276ce)

[matoous]

Would require " to be added as a pair here: https://github.com/helix-editor/helix/blob/master/helix-core/src/surround.rs#L6, nothing more is needed afaik. While at it, ` and ' might also be good candidates.

[dgmulf]

Perhaps mim should automatically work with all pairs defined in the [editor.auto-pairs] config key?

[lukepighetti]

Would require " to be added as a pair here: https://github.com/helix-editor/helix/blob/master/helix-core/src/surround.rs#L6, nothing more is needed afaik. While at it, and'` might also be good candidates.

Interestingly, I did try that, but after compile it wasn't working. I noticed that we have no cases where open and close characters are identical, and I wonder if the existing code is not setup to handle this case.

[matoous]

@lukepighetti your are right. I will try to take a look over the weekend 👀
Edit: tried, struggled with it, went to work on other PRs where I felt more confident. Free for grab or I will revisit this once done with other stuff.

[lukepighetti]

Looks like @sudormrfbin was the last to touch this part of the codebase. Maybe he has some tips for us.

[asvln]

Interestingly, I did try that, but after compile it wasn't working. I noticed that we have no cases where open and close characters are identical, and I wonder if the existing code is not setup to handle this case.

Note for future implementors, adding any character pair (same or not) to the PAIRS const in surround.rs does not make them work with mim.

[thomasaarholt]

This doesn't seem completely fixed yet. Here I show examples in python and rust on the latest master.

I have working LSPs for both languages.

❯ hx --health python
Configured language servers:
  ✓ pyright-langserver: /opt/homebrew/bin/pyright-langserver
  ✓ ruff-lsp: /opt/homebrew/bin/ruff-lsp
Configured debug adapter: None
Configured formatter: None
Highlight queries: ✓
Textobject queries: ✓
Indent queries: ✓

❯ hx --health rust
Configured language servers:
  ✓ rust-analyzer: /opt/homebrew/bin/rust-analyzer
Configured debug adapter: lldb-dap
Binary for debug adapter: 'lldb-dap' not found in $PATH
Configured formatter: None
Highlight queries: ✓
Textobject queries: ✓
Indent queries: ✓

For testing:

foo_python = "mim does not work on this string"

let foo_rust = "mim only works when the cursor is positioned on the first \""

I observe that mm doesn't work on strings in Python, and that mim only works for the first quotation mark in Rust, and not at all in Python.

[pascalkuthe]

Those two things are unrelated. The python case has an odd grammar for the string literal which is not being handeled due to an existing bug kn mm (I am aware of). The case of mim not working on the second quote is likely a bug in the new mim implementation.

U don't think it's useful to necormamce old issues that are mostly solved except some edgecase burried kn the comments.

[woojiq]

@thomasaarholt hey, thanks for the reproduction steps.
I agree with @pascalkuthe about mm bug. But anyway thanks for detailed asciinema, I see some inconsistency in the new behavior as well. I will look at the weekend.

[thomasaarholt]

@pascalkuthe, the main reason I didn't create a new issue was that this one was closed 48 hours ago. I was honestly worried about being told off for making a new issue, which is why I commented here. 🤷
Thank you for identifying for me that mm is a problem with the Python side.

@woojiq, thank you! I really appreciate your contribution, it's one that makes helix feel even more intuitive to me!