Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select change range for goto_first/last_change commands #5206

Merged

Conversation

the-mikedavis
Copy link
Member

This matches the behavior from #4713 but for the first and last change. The selection rules are the same as for goto_next/prev_change: additions and modifications select the added and modified range while deletions are represented with a point.

This matches the behavior from 42ad1a9
but for the first and last change. The selection rules are the same
as for goto_next/prev_change: additions and modifications select the
added and modified range while deletions are represented with a point.
@the-mikedavis the-mikedavis added A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Dec 18, 2022
Copy link
Member

@pascalkuthe pascalkuthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that! I should have included that in the original PR after your comment but forgot about goto_first_change / goto_last_change. I actually hadn't noticed this yet, apparently I don't really use those motions :D

@kirawi kirawi added the C-bug Category: This is a bug label Jan 1, 2023
@pascalkuthe pascalkuthe added this to the next milestone Jan 6, 2023
@archseer archseer merged commit 23ed8c1 into helix-editor:master Feb 7, 2023
@the-mikedavis the-mikedavis deleted the md-first-last-change-sel branch February 7, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants