Hilighting broken on themes which use italics

[glfmn]

Summary

When setting the styling of comments for a theme, the following results in unexpected styling:

"comment" = { fg = "gray1", modifiers = ["italic"]  }

However, it does work when using the following forms:

"comment" = "gray1"
"comment" = { fg = "bg0", bg = "gray1" }
"comment" = { fg = "gray1", modifiers = ["bold"] }

Reproduction Steps

Select the gruvbox theme (or any theme which uses italics for comment syntax hilighting).

Create a new theme which inherits from it and override the comment style. Toggle between the themes and observe that themes with modifiers do not have the correct output.

# Modify the gruvbox theme
inherits = "gruvbox"

# Change the look of comments
"comment" = "gray1"

I have not tested anything other than comments, but it could just be an issue with italics in general.

Helix log

~/.cache/helix/helix.log

2022-12-19T13:18:16.648 helix_view::theme [WARN] Theme: malformed hexcode: test

Platform

Linux

Terminal Emulator

alacritty 0.9.0

Helix Version

helix 22.12 (ec9aa66)

[kirawi]

Is this a dupe of #3099?

[glfmn]

Yes, didn't think to check if tmux/byobu was the issue!