fix(commands): extend_line to proper line when count and current line selected #5288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for both extend_line_(above/below) the check for if current line is selected now works if there is a count
the-mikedavis
added
C-bug
|
Sorry about that, I was thinking about doing that but totally forgot. Integration tests have been added now, it needed a trailing newline to work cause the test would add an extra newline after end if it didn't exist. |
the-mikedavis
approved these changes
Dec 31, 2022
semin-park
pushed a commit
to semin-park/helix
that referenced
this pull request
Jan 4, 2023
semin-park
pushed a commit
to semin-park/helix
that referenced
this pull request
Jan 4, 2023
hadronized
pushed a commit
to hadronized/helix
that referenced
this pull request
Jan 4, 2023
freqmod
pushed a commit
to freqmod/helix
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for both extend_line_(above/below) the check for if current line is selected now works if there is a count:
this now means if you select a line with
xand then do2x3 lines will be selected whereas before only 2 lines would be, this keeps2xon a not fully selected line only selecting 2 lines which is the desired functionality ofextend_linefixes #5270