Store new config on application in :config-reload #5431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After changes in helix-editor#5239, the loaded configuration wasn't stored, resulting in a success message even if the instance kept the previous configuration values.
the-mikedavis
approved these changes
Jan 8, 2023
the-mikedavis
changed the title
kirawi
pushed a commit
to kirawi/helix
that referenced
this pull request
Jan 25, 2023
After changes in helix-editor#5239, the loaded configuration wasn't stored, resulting in a success message even if the instance kept the previous configuration values.
freqmod
pushed a commit
to freqmod/helix
that referenced
this pull request
Feb 8, 2023
After changes in helix-editor#5239, the loaded configuration wasn't stored, resulting in a success message even if the instance kept the previous configuration values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After changes in #5239, the loaded configuration wasn't stored, resulting in a success message even if the instance kept the previous configuration values.