Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use filename completer on run-shell-command #5729

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Use filename completer on run-shell-command #5729

merged 1 commit into from
Jan 30, 2023

Conversation

xJonathanLEI
Copy link
Contributor

This PR changes to use the filename completer on the run-shell-command typed command. With the current completer:

  • I find myself having to type out the filename myself most of the time anyways when using sh for file operations like chmod and rm;
  • One would have to manually append / to get new completions for the next directory level, which is sub-optimal.

Switching to use filename conveniently solves both issues.

@pascalkuthe pascalkuthe added S-waiting-on-review Status: Awaiting review from a maintainer. E-easy Call for participation: Experience needed to fix: Easy / not much A-helix-term Area: Helix term improvements labels Jan 30, 2023
@the-mikedavis the-mikedavis linked an issue Jan 30, 2023 that may be closed by this pull request
:sh tab completion cycles through directory names only, not file names or program names #5338
Closed
@the-mikedavis the-mikedavis merged commit 86ae81e into helix-editor:master Jan 30, 2023
@xJonathanLEI xJonathanLEI deleted the dev/sh_completer branch January 30, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-helix-term Area: Helix term improvements E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

:sh tab completion cycles through directory names only, not file names or program names
3 participants
@xJonathanLEI @the-mikedavis @pascalkuthe