Text rendering error

[shengliawa]

Summary

When I move the cursor up at the end of the file.
A lot of cursors appear suddenly and the text obviously renders incorrectly

Reproduction Steps

I tried this:

1. hx

I expected this to happen:
Font rendering is normal
Instead, this happened:

Helix log

~/.cache/helix/helix.log

2023-01-31T17:12:01.648 helix_view::editor [ERROR] editor error: LSP not defined for the current document
2023-01-31T17:14:21.673 helix_view::editor [ERROR] editor error: no such command: 'fomat'
2023-01-31T18:57:48.061 helix_view::editor [ERROR] Failed to initialize the LSP for `source.toml` { cannot find binary path }
2023-01-31T19:16:16.044 helix_view::editor [ERROR] Failed to initialize the LSP for `source.md` { cannot find binary path }
2023-01-31T19:18:12.198 helix_view::editor [ERROR] Failed to initialize the LSP for `source.md` { cannot find binary path }
2023-01-31T19:20:34.788 helix_view::editor [ERROR] editor error: 1 unsaved buffer(s) remaining: ["[scratch]"]
2023-01-31T19:21:32.108 helix_view::editor [ERROR] Failed to initialize the LSP for `source.md` { cannot find binary path }
2023-01-31T21:50:39.258 helix_view::editor [ERROR] Failed to initialize the LSP for `source.rust` { cannot find binary path }
2023-01-31T22:12:24.896 helix_view::editor [ERROR] Failed to initialize the LSP for `source.md` { cannot find binary path }
2023-01-31T22:40:23.650 helix_view::editor [ERROR] Failed to initialize the LSP for `source.md` { cannot find binary path }
2023-01-31T22:41:01.429 helix_view::editor [ERROR] Failed to initialize the LSP for `source.md` { cannot find binary path }

Platform

Windows

Terminal Emulator

Original PowerShell 7.3.2

Helix Version

helix 22.12 (96ff64a)

[pascalkuthe]

Could you upload the file where this happens? That would help a lot with debugging the issue. Also just to clarify: You have placed the cursor at the end of the file and then press k once?

[shengliawa]

index.md
This is the file.I did press k to move the cursor up.

[CptPotato]

I cannot reproduce this using Wezterm, Cmd or Powershell on Windows 10. I'm using a somewhat recent commit from master.

[LeoniePhiline]

I also can not reproduce this using Konsole on OpenSUSE Tumbleweed, using 447909e, which is the master HEAD from yesterday.

My repro steps:

@shengliawa Please check if this matches your steps to crash. Could be I misunderstood you.

Option 1 - last char of last line:

1. hx /path/to/index.md
2. g e
3. g l
4. k (once, then multiple times - nothing out of the ordinary happens)
5. : q Enter

Option 2 - past the last char of last line:

1. hx /path/to/index.md
2. g e
3. g l
4. Added: l
5. k (once, then multiple times - nothing out of the ordinary happens)
6. : q Enter

@shengliawa Could you try with the latest master?

[shengliawa]

I compiled the version from master. helix 22.12 4eca4b3.
It always has problems when I move the cursor around.


They should be like this.


**

[LeoniePhiline]

Are you able to make a screen recording of that?

I moved around, copy-pasted selections etc. in your file, but I observed no messed up texts.

[shengliawa]

https://raw.githubusercontent.com/shengliawa/shengliawa.github.io/main/helix.mp4
This is the screen recording.

[kirawi]

I experience this on my Windows machine with Alacritty and Korean/Japanese/Chinese, but I never filed a bug report assuming it was an issue with the terminal (Wezterm works fine). It could alternatively have something to do with the font, version of conpty, or alacritty/alacritty#1295. I don't know.

Additional behavior I experience:

The text below the English is not empty, it's just not rendered until insert mode is exited.

[shengliawa]

OK, Helix's font rendering is normal under WezTerm,Thank you.
@kirawi

[LeoniePhiline]

I could imagine this should be noted in the README.md or the documentation?

A PR adding a heads-up for Windows users of CJK languages, and a recommendation to use Wezterm could potentially help many others.

[gabydd]

There is actually a terminal support page on the wiki https://github.com/helix-editor/helix/wiki/Terminal-Support so a note could be added there

[LeoniePhiline]

I added a note: https://github.com/helix-editor/helix/wiki/Terminal-Support/_compare/5412a09bd46ed5aa3edc9cb0f98e8a888be4eb1d...55b5772122526693a9af5f120f95c4adba71f63f

Still think there should be a "Requirements" page or similar, text to https://docs.helix-editor.com/install.html - the wiki isn't as easy to be found as the documentation. (And I wouldn't expect both in parallel to exist and be relevant and up to date.)