Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exit code to command failed msg #5898

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Add exit code to command failed msg #5898

merged 1 commit into from
Feb 10, 2023

Conversation

lesleyrs
Copy link
Contributor

@lesleyrs lesleyrs commented Feb 10, 2023

Closes #5716 (last pr here #5885)

Added the actual exit code to the Shell command failed message to be less ambiguous. Main reason is because some commands still succeed with exit codes other than 0.

Thx @CptPotato for the explanation. 👍

@kirawi kirawi added A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Feb 10, 2023
@the-mikedavis the-mikedavis merged commit af1157f into helix-editor:master Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading message: Shell command failed
3 participants