Scroll cursor and page together (neovim-like scrolling) #8015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderDickie
force-pushed
the
nvim-scroll-1
branch
from
8c6d543
to
4f2a143
Compare
AlexanderDickie
force-pushed
the
nvim-scroll-1
branch
from
4f2a143
to
1fe59ea
Compare
archseer
reviewed
Aug 20, 2023
pascalkuthe
added
E-easy
pascalkuthe
reviewed
Aug 21, 2023
pascalkuthe
reviewed
Aug 21, 2023
pascalkuthe
reviewed
Aug 21, 2023
pascalkuthe
previously approved these changes
Aug 21, 2023
|
looks like formatting still needs to be fixed tough |
|
(and some clippy lints) |
pascalkuthe
previously approved these changes
Aug 21, 2023
|
Does this require the documentation to be updated? |
|
Can we get the labels changed on this so it gets reviewed? 😄 |
pascalkuthe
added
S-waiting-on-review
|
The labels don't really affect what we review too much. It's mostly for other people |
the-mikedavis
approved these changes
Feb 18, 2024
pascalkuthe
approved these changes
Feb 18, 2024
uek-1
pushed a commit
to uek-1/helix
that referenced
this pull request
Feb 24, 2024
…#8015) * neovim like scroll function * clear line annotations outside of move_vertically/_visual * add nvim scroll function to commands * assign nvim-scroll to C-d and C-u (half page scrolls) * dont remove backspace and space mapping * move non-softwrap logic to seperate function, call this in nvim-scroll fn * Revert "move non-softwrap logic to seperate function, call this in nvim-scroll fn" This reverts commit e490572. * Revert "clear line annotations outside of move_vertically/_visual" This reverts commit 1df3fef. * add TODO for when inline diagnostics gets merged * move nvim-scroll logic into scroll(), dont respect scrolloff * run cargo fmt * run cargo clippy * update documenation for Ctrl-d and Ctrl-u remap
2639-unofficial
added a commit
to 2639-unofficial/krustallos
that referenced
this pull request
Mar 1, 2024
C-u/d config is no longer needed after helix-editor/helix#8015
shortc
pushed a commit
to shortc/helix
that referenced
this pull request
Mar 31, 2024
…#8015) * neovim like scroll function * clear line annotations outside of move_vertically/_visual * add nvim scroll function to commands * assign nvim-scroll to C-d and C-u (half page scrolls) * dont remove backspace and space mapping * move non-softwrap logic to seperate function, call this in nvim-scroll fn * Revert "move non-softwrap logic to seperate function, call this in nvim-scroll fn" This reverts commit e490572. * Revert "clear line annotations outside of move_vertically/_visual" This reverts commit 1df3fef. * add TODO for when inline diagnostics gets merged * move nvim-scroll logic into scroll(), dont respect scrolloff * run cargo fmt * run cargo clippy * update documenation for Ctrl-d and Ctrl-u remap
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
…#8015) * neovim like scroll function * clear line annotations outside of move_vertically/_visual * add nvim scroll function to commands * assign nvim-scroll to C-d and C-u (half page scrolls) * dont remove backspace and space mapping * move non-softwrap logic to seperate function, call this in nvim-scroll fn * Revert "move non-softwrap logic to seperate function, call this in nvim-scroll fn" This reverts commit e490572. * Revert "clear line annotations outside of move_vertically/_visual" This reverts commit 1df3fef. * add TODO for when inline diagnostics gets merged * move nvim-scroll logic into scroll(), dont respect scrolloff * run cargo fmt * run cargo clippy * update documenation for Ctrl-d and Ctrl-u remap
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
…#8015) * neovim like scroll function * clear line annotations outside of move_vertically/_visual * add nvim scroll function to commands * assign nvim-scroll to C-d and C-u (half page scrolls) * dont remove backspace and space mapping * move non-softwrap logic to seperate function, call this in nvim-scroll fn * Revert "move non-softwrap logic to seperate function, call this in nvim-scroll fn" This reverts commit e490572. * Revert "clear line annotations outside of move_vertically/_visual" This reverts commit 1df3fef. * add TODO for when inline diagnostics gets merged * move nvim-scroll logic into scroll(), dont respect scrolloff * run cargo fmt * run cargo clippy * update documenation for Ctrl-d and Ctrl-u remap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #7639 - adds a new scroll function so that the cursor and page jump by the same distance vertically. Assigns this to C-u and C-d, similar to neovim.
The consistent distance between cursor and view top would break if the cursor were to land on a whole line of virtual text- the cursor would be placed on the closest non-virtual text above where it landed. Meaning the view and cursor would not have jumped the same vertical distance.
This should be pretty rare though- unless you are using #6417 and have a ton of error messages. I could refactor this nvim-scroll function though- to first calculate how many lines the cursor jumped (eg the cursor tried to jump by half a page but could only jump by half a page -1 line due to virtual text) and then move the view by exactly this number. This would change the behaviour at the bottom of the page a bit also.
This nvim-scroll function respects the cursor's column throughout scrolls which I think is nice, I will make a pr for the
scrollfunction to have the same.Closes #7639