Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate homebrew tap updates via CI #9

Closed
archseer opened this issue May 11, 2021 · 11 comments
Closed

Automate homebrew tap updates via CI #9

archseer opened this issue May 11, 2021 · 11 comments
Labels
A-packaging Area: Packaging and bundling E-easy Call for participation: Experience needed to fix: Easy / not much

Comments

@archseer
Copy link
Member

We'd like to distribute the package via a Homebrew tap on OSX.

@archseer archseer added E-easy Call for participation: Experience needed to fix: Easy / not much A-packaging Area: Packaging and bundling labels May 11, 2021
@skyfaller
Copy link

skyfaller commented Jun 1, 2021

Can you please make sure the Homebrew tap works on Linux as well? I use Homebrew on Pop OS for everything that is too new to be in the Pop Shop / apt / Flatpak. https://docs.brew.sh/Homebrew-on-Linux

@tbillington
Copy link

Why a tap? Why not just add to homebrew actual.

@archseer
Copy link
Member Author

archseer commented Jun 2, 2021

The project is still very alpha, so we'll probably cut new point releases often for the time being (consider it more like nightly builds). Would be a pain to update on homebrew-core continuously. Will make sense to do once we have a stable release though.

@lewiscowper
Copy link

on a similar note, is it feasible (I can open a new Issue if so), to support apple silicon builds?

@archseer
Copy link
Member Author

archseer commented Jun 3, 2021

@lewiscowper It should be as simple as adding aarch64-apple-darwin to the build matrix:

matrix:
build: [x86_64-linux, aarch64-linux, x86_64-macos, x86_64-windows] #, x86_64-win-gnu, win32-msvc
include:
- build: x86_64-linux
os: ubuntu-20.04
rust: stable
target: x86_64-unknown-linux-gnu
cross: false
- build: aarch64-linux
os: ubuntu-20.04
rust: stable
target: aarch64-unknown-linux-gnu
cross: true
- build: x86_64-macos
os: macos-latest
rust: stable
target: x86_64-apple-darwin
cross: false
- build: x86_64-windows
os: windows-2019
rust: stable
target: x86_64-pc-windows-msvc
cross: false
# - build: x86_64-win-gnu
# os: windows-2019
# rust: stable-x86_64-gnu
# target: x86_64-pc-windows-gnu
# - build: win32-msvc
# os: windows-2019
# rust: stable
# target: i686-pc-windows-msvc

I didn't include it before when the codebase was private since macOS builds cost 10x CI time for rivate repos

@archseer
Copy link
Member Author

archseer commented Jun 3, 2021

There's a macOS tap available now: https://github.com/helix-editor/homebrew-helix, courtesy of @ethanbodzioney

@hovsater
Copy link
Contributor

hovsater commented Jun 6, 2021

@archseer should we close this then? 🙂

@archseer
Copy link
Member Author

archseer commented Jun 7, 2021

I'd like to automate the tap updates on the CI, then the issue can be closed :)

@archseer archseer changed the title Add a Homebrew tap Automate homebrew tap updates via CI Jun 10, 2021
@hovsater
Copy link
Contributor

Could this be closed now since we decided to drop the tap altogether?

@archseer
Copy link
Member Author

We should still upstream to Homebrew first.

@archseer
Copy link
Member Author

Recipe was upstreamed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-packaging Area: Packaging and bundling E-easy Call for participation: Experience needed to fix: Easy / not much
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants