Add Groovy grammar #9350
Merged
Add Groovy grammar #9350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
requested changes
Jan 16, 2024
the-mikedavis
added
S-waiting-on-author
the-mikedavis
added
S-waiting-on-review
|
@chernetskyi any chance to get he merge conflicts resolved? |
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Done. Hopefully, it will be merged soon, so no new conflicts can appear. |
the-mikedavis
approved these changes
Feb 19, 2024
pascalkuthe
approved these changes
Feb 19, 2024
|
It looks like nvim-treesitter switched to a more complete parser just recently: nvim-treesitter/nvim-treesitter@d4dac52 Should we update helix with these changes as well? |
|
Feel free to open up a PR switching the parser and queries if it's an improvement |
|
@the-mikedavis here you go! #9677 |
uek-1
pushed a commit
to uek-1/helix
that referenced
this pull request
Feb 24, 2024
* Add Groovy grammar * Rewrite Neovim captures into Helix for Groovy * Simplify Groovy injections Co-authored-by: Michael Davis <mcarsondavis@gmail.com> * Remove Neovim's spell from Groovy highlights Co-authored-by: Michael Davis <mcarsondavis@gmail.com> * Apply suggestions to languages.toml * Escape backslash in groovy highlights.scm --------- Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
shortc
pushed a commit
to shortc/helix
that referenced
this pull request
Mar 31, 2024
* Add Groovy grammar * Rewrite Neovim captures into Helix for Groovy * Simplify Groovy injections Co-authored-by: Michael Davis <mcarsondavis@gmail.com> * Remove Neovim's spell from Groovy highlights Co-authored-by: Michael Davis <mcarsondavis@gmail.com> * Apply suggestions to languages.toml * Escape backslash in groovy highlights.scm --------- Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
* Add Groovy grammar * Rewrite Neovim captures into Helix for Groovy * Simplify Groovy injections Co-authored-by: Michael Davis <mcarsondavis@gmail.com> * Remove Neovim's spell from Groovy highlights Co-authored-by: Michael Davis <mcarsondavis@gmail.com> * Apply suggestions to languages.toml * Escape backslash in groovy highlights.scm --------- Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
* Add Groovy grammar * Rewrite Neovim captures into Helix for Groovy * Simplify Groovy injections Co-authored-by: Michael Davis <mcarsondavis@gmail.com> * Remove Neovim's spell from Groovy highlights Co-authored-by: Michael Davis <mcarsondavis@gmail.com> * Apply suggestions to languages.toml * Escape backslash in groovy highlights.scm --------- Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4211
Took queries from nvim-treesitter.