Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a yank diagnostic command #9640

Merged
merged 4 commits into from Mar 15, 2024
Merged

Add a yank diagnostic command #9640

merged 4 commits into from Mar 15, 2024

Conversation

kirawi
Copy link
Member

@kirawi kirawi commented Feb 16, 2024

Resolves #9527

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. A-command Area: Commands labels Feb 16, 2024
@the-mikedavis the-mikedavis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from a maintainer. labels Feb 18, 2024
@kirawi kirawi added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 18, 2024
the-mikedavis
the-mikedavis previously approved these changes Feb 18, 2024
View reviewed changes
@kirawi kirawi added the E-easy Call for participation: Experience needed to fix: Easy / not much label Feb 28, 2024
zetashift
zetashift approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@zetashift zetashift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My Rust knowledge is limited, but from I've had no problems running this branch and the codechange is small but readable.

Easy diagnostics sharing is essential for mewhen communicating errors and filing tickets, so thank you very much for this!

@pascalkuthe
Copy link
Member

Discussed thsi with @the-mikedavis. This should be a typable command since it's so.ething you just need occasionally and will not be bound by default

pascalkuthe
pascalkuthe previously approved these changes Mar 15, 2024
View reviewed changes
@kirawi
Copy link
Member Author

kirawi commented Mar 15, 2024

Sorry about that, I forgot to change some uses of set_error to bail. It's finished now.

@pascalkuthe
Copy link
Member

looks like you need to commit docgen

@pascalkuthe pascalkuthe merged commit 0c51ab1 into helix-editor:master Mar 15, 2024
6 checks passed
@kirawi kirawi deleted the lsp-yank branch March 15, 2024 23:55
@kirawi kirawi mentioned this pull request Mar 18, 2024
Closed
@adriangalilea
Copy link

Sorry to ask here, but how is the yank diagnostic command performed?

@the-mikedavis
Copy link
Member

It's a typable command so you can use it command mode, similar to :write. In normal mode use : to enter command mode then type yank-diagnostic and hit Enter

@adriangalilea
Copy link

adriangalilea commented Mar 21, 2024 •
edited

I could not find it in the docs, this is why I ask :)
I also get, no such command: 'yank-diagnostic' when I try to use it

@kirawi
Copy link
Member Author

kirawi commented Mar 21, 2024 •
edited

This will be the in the upcoming release. The docs you linked are also for the latest release; not master (https://docs.helix-editor.com/master/commands.html)

Desdaemon pushed a commit to Desdaemon/helix that referenced this pull request Mar 26, 2024
@kirawi @Desdaemon
Add a yank diagnostic command (helix-editor#9640)
f67cd59 
* yank diagnostic command

* improve success message

* move to a typed command

* docgen
shortc pushed a commit to shortc/helix that referenced this pull request Mar 31, 2024
@kirawi @chrisshort-udig
Add a yank diagnostic command (helix-editor#9640)
a7f384c 
* yank diagnostic command

* improve success message

* move to a typed command

* docgen
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@kirawi @postsolar
Add a yank diagnostic command (helix-editor#9640)
88aa9ca 
* yank diagnostic command

* improve success message

* move to a typed command

* docgen
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@kirawi @postsolar
Add a yank diagnostic command (helix-editor#9640)
ddb6229 
* yank diagnostic command

* improve success message

* move to a typed command

* docgen
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@kirawi @postsolar
Add a yank diagnostic command (helix-editor#9640)
e528cc1 
* yank diagnostic command

* improve success message

* move to a typed command

* docgen
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 6, 2024
@kirawi @postsolar
Add a yank diagnostic command (helix-editor#9640)
1210c58 
* yank diagnostic command

* improve success message

* move to a typed command

* docgen
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 11, 2024
@kirawi @postsolar
Add a yank diagnostic command (helix-editor#9640)
d97f803 
* yank diagnostic command

* improve success message

* move to a typed command

* docgen
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
@kirawi @postsolar
Add a yank diagnostic command (helix-editor#9640)
dcd2b8c 
* yank diagnostic command

* improve success message

* move to a typed command

* docgen
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
@kirawi @postsolar
Add a yank diagnostic command (helix-editor#9640)
2724a21 
* yank diagnostic command

* improve success message

* move to a typed command

* docgen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetashift zetashift zetashift approved these changes

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@pascalkuthe pascalkuthe pascalkuthe approved these changes

Assignees
No one assigned
Labels
A-command Area: Commands E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add command to yank diagnostic under cursor
5 participants
@kirawi @pascalkuthe @adriangalilea @the-mikedavis @zetashift