Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete and move/rename buffer and associated file commands #9682

Closed
Kim-Dewelski opened this issue Feb 20, 2024 · 3 comments
Closed

Delete and move/rename buffer and associated file commands #9682

Kim-Dewelski opened this issue Feb 20, 2024 · 3 comments
Labels
C-enhancement Category: Improvements R-duplicate Duplicated issue: please refer to the linked issue

Comments

@Kim-Dewelski
Copy link

Kim-Dewelski commented Feb 20, 2024

I personally find it somewhat annoying that Helix is able to create new files via the open command, but lacks the ability to delete a buffer and its associated file, or move/rename a file associated with a buffer to a different location. If I remove a file externally via something like rm, the buffer remains alive and it is very easy to accidentally create the old file from the buffer again. This is great and all in a lot of cases, but sometimes I just want to close a buffer and delete its associated file, so I believe helix would benefit from these additions.

@Kim-Dewelski Kim-Dewelski added the C-enhancement Category: Improvements label Feb 20, 2024
@kirawi
Copy link
Member

kirawi commented Feb 20, 2024

Move is supported on master via the LSP spec. We can also support deleting files (and opening files) through the LSP spec. I'm not sure how Blaz feels about having a non-LSP implementation.

@Kim-Dewelski
Copy link
Author

What are some of the reason to not include a :delete command which just closes the buffer, and deletes the associated underlying file? Is there a technical or opinionated reason mainly? I would gladly love to make a PR if I know it would be considered.

@kirawi
Copy link
Member

kirawi commented Feb 21, 2024

This is actually a duplicate of #4592

@kirawi kirawi closed this as completed Feb 21, 2024
@kirawi kirawi closed this as not planned Won't fix, can't repro, duplicate, stale Feb 21, 2024
@kirawi kirawi added the R-duplicate Duplicated issue: please refer to the linked issue label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Improvements R-duplicate Duplicated issue: please refer to the linked issue
Projects
None yet
Development

No branches or pull requests

2 participants