Completely fix bash autocomplete handling of filenames with spaces #9708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix additional bug when file names contain spaces. ## Broken behavior - Assume the current directory contains the file "foo bar.txt" and "foo biz.txt" - `hx foo\ ba` + `Tab` autocompletes to `hx foo\ b` ## New behavior - `hx foo\ ba` + `Tab` autocompletes to `hx foo\ bar.txt`
the-mikedavis
approved these changes
Feb 23, 2024
the-mikedavis
added
the
S-waiting-on-review
archseer
approved these changes
Feb 24, 2024
uek-1
pushed a commit
to uek-1/helix
that referenced
this pull request
Feb 24, 2024
ofzo
pushed a commit
to ofzo/helix-editor
that referenced
this pull request
Feb 26, 2024
shortc
pushed a commit
to shortc/helix
that referenced
this pull request
Mar 31, 2024
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made an PR earlier (#9702) to fix issue #9701, but it seems that I forgot to wrap a
$2in quotes and escape the quotes in some of the lines above. With this mistake, most of the behavior when filenames include spaces still works properly, but some problems still occur when multiple file paths are similar and contain spaces.Broken behavior
hx foo\ ba+Tabautocompletes tohx foo\ bhx foo\ biz+Tabautocompletes tohx foo\ bNew behavior
hx foo\ ba+Tabautocompletes tohx foo\ bar.txthx foo\ biz+Tabautocompletes tohx foo\ biz.txtTesting
/usr/share/bash-completion/completions/hxwith the new contents ofcontrib/completion/hx.bash.