Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(languages): add support for *.Dockerfile file-types naming convention #9772

Merged

Conversation

RoloEdits
Copy link
Contributor

Current file-types only supports up to a Dockerfile.frontend naming scheme.

With these changes frontend.Dockerfile now gives proper highlights and lsp actions.

languages.toml Outdated Show resolved Hide resolved
@the-mikedavis the-mikedavis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. A-language-support Area: Support for programming/text languages labels Mar 1, 2024
@RoloEdits RoloEdits force-pushed the dot-dockerfile-file-types branch 2 times, most recently from 59c7310 to 2bf1879 Compare March 2, 2024 06:06
languages.toml Outdated Show resolved Hide resolved
languages.toml Outdated Show resolved Hide resolved
…onvention

Current `file-types` only supports up to a `Dockerfile.frontend` naming scheme.

With these changes `frontend.Dockerfile` now gives proper highlights and lsp actions.
@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 3, 2024
@pascalkuthe pascalkuthe merged commit cc43e35 into helix-editor:master Mar 3, 2024
6 checks passed
Desdaemon pushed a commit to Desdaemon/helix that referenced this pull request Mar 4, 2024
…onvention (helix-editor#9772)

Current `file-types` only supports up to a `Dockerfile.frontend` naming scheme.

With these changes `frontend.Dockerfile` now gives proper highlights and lsp actions.
@RoloEdits RoloEdits deleted the dot-dockerfile-file-types branch March 4, 2024 01:30
shortc pushed a commit to shortc/helix that referenced this pull request Mar 31, 2024
…onvention (helix-editor#9772)

Current `file-types` only supports up to a `Dockerfile.frontend` naming scheme.

With these changes `frontend.Dockerfile` now gives proper highlights and lsp actions.
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
…onvention (helix-editor#9772)

Current `file-types` only supports up to a `Dockerfile.frontend` naming scheme.

With these changes `frontend.Dockerfile` now gives proper highlights and lsp actions.
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
…onvention (helix-editor#9772)

Current `file-types` only supports up to a `Dockerfile.frontend` naming scheme.

With these changes `frontend.Dockerfile` now gives proper highlights and lsp actions.
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
…onvention (helix-editor#9772)

Current `file-types` only supports up to a `Dockerfile.frontend` naming scheme.

With these changes `frontend.Dockerfile` now gives proper highlights and lsp actions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants