Handle starting and continuing the count separately #9887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to handle number key events differently depending on whether the count has been started or not: * If the count has been started, any number will continue the count. * If the count hasn't been started yet, a non-zero numeric key can start the count if it isn't bound to a command. This supports custom bindings for any of the number keys. (Though those bindings cannot use counts.)
the-mikedavis
added
C-bug
pascalkuthe
approved these changes
Mar 15, 2024
archseer
approved these changes
Mar 15, 2024
Desdaemon
pushed a commit
to Desdaemon/helix
that referenced
this pull request
Mar 26, 2024
shortc
pushed a commit
to shortc/helix
that referenced
this pull request
Mar 31, 2024
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to handle number key events differently depending on whether the count has been started or not:
This supports custom bindings for any of the number keys. (Though those bindings cannot use counts.)
Fixes #9871