feat: add support for gjs and gts

[c0rydoras]

Add support for glimmer-js and glimmer-ts

gjs

gts

(error due to using linguist sample and missing imports)

[the-mikedavis]

We don't support #offset!. This will also need to be updated to use injection.content and injection.language rather than tagging with @glimmer - that's the way nvim-treesitter did injections in the past.

Something like

(call_expression
  function: ((identifier) @_name
             (#eq? @_name "hbs"))
  arguments: ((template_string) @injection.content
              (#set! injection.language "glimmer")))

[c0rydoras]

This can probably just be dropped due to RFC 0779

As of [RFC 0779][rfc-0779], we decided on <template> over hbs; see the RFC for the full rationale. The hbs format is still technically supported by this repo for transition purposes for the early adopters who helped us get here, but will be removed at some point in the near future! hbs has been removed -- if you rely on this feature, please use ember-template-imports @ < v4, until migrated to <template>

If anywhere this probably belongs into the javascript/typescript injections instead of gjs

[the-mikedavis]

Yeah let's drop this pattern. It won't do anything in its current form anyways because of the @glimmer capture

[David-Else]

It is great we are finally getting a config for [language-server.vscode-eslint-language-server]! I have not used eslint for ages, but I am interested in making sure Helix support is as generic and unopinionated as possible. I created a discussion about it: #8452

You config seems cool, my only question is should we use experimental = { useFlatConfig = false }?

https://eslint.org/blog/2022/08/new-config-system-part-2/
https://stackoverflow.com/questions/78330131/how-do-i-configure-eslint-flat-config-with-typescript-in-vscode-without-flatco

Is FlatConfig not the current standard? Typescript ESlint seems to use it and describes the old one as legacy: https://typescript-eslint.io/getting-started/

Forgive my ignorance on this topic, I thought I would bring it up but don't really have any answers, only questions. Perhaps @Philipp-M could comment?

[c0rydoras]

AFAIK eslint is almost always used within ember.js apps/addons

Ember ships with eslint per default: app blueprint

Using eslint-plugin-ember is the only way i found to get useful diagnostics

For reference, using typescript-language-server looks like this:

eslint-language-server itself isn't really that useful for things other than diagnostics and formatting so i still included typescript-language-server for that and omitted the diagnostics. This definitely isn't ideal but the best solution I found.

I just contributed my local config upstream, therefore theres things such as

[language-server.eslint.config]
experimental = { useFlatConfig = false }

If there is something like "per language" LSP configurations it would probably make sense to not configure this for other languages.

[David-Else]

If there is something like "per language" LSP configurations it would probably make sense to not configure this for other languages.

I think each LSP config is universal in Helix.

We should probably use the equivalent of the Neovim config for eslint: https://github.com/neovim/nvim-lspconfig/blob/master/doc/server_configurations.md#eslint . It looks almost the same as the one in this PR, they also have experimental = { useFlatConfig = false }. Regarding the following from Neovim:

{
  codeActionOnSave = {
    enable = false,
    mode = "all"
}, 

My understanding is that codeActionOnSave does not work in Helix at this point, but do we want to explicitly turn it off like Neovim?