Make WASD customizable

[hellerve]

WASD is not ergonomic on some keyboard layouts, and it would be a good idea to create a simple way to change them. Currently, we do these movements in a switch statement, meaning we cannot have non-constants. It would make sense to make this scriptable through Lua, though.

Thanks to this comment on HN for making me aware of this issue.

[Kausta]

The switch part seems easy as it can be done with refactoring it to if cases. However, a config system is probably required to handle/take different keys and it would be also good in general to have configurable settings.

I could help, but the config type/file format should be discussed first.

[hellerve]

That’s not really a problem. The struct e_context already has a config option (the tab width), which is also settable through Lua. A simple way to refactor this then would be to put the keys into the e_context struct (or maybe even add a e_config struct) and then add Lua setters and getters.

[hellerve]

PR #17 should fix this. I’ll merge it within the next 24 hours if there are no objections.

[kianmeng]

Does this means we can use hjkl for cursor movement after this PR?

[hellerve]

I’m afraid not, because h (hide) still takes precedence. I’ve thought about the precedence rules, and I firmly believe that having sensible defaults is more important than making it extremely customizable. Thus I’d rather talk about changing those if the need arises.

[hellerve]

PR was merged, I’ll close this for now.