Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical drag with Safari 15 on iOS is cancelled when the address bar grow #240

Open
100terres opened this issue Mar 14, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@100terres
Copy link
Collaborator

Issue originally opened on react-beautiful-dnd repository: atlassian/react-beautiful-dnd#2367

In iOS 15 Safari shows/hides address bar at appropriate scroll position, and every show/hide will fire resize event. The library cancels dragging on resize event, so automatic scrolling causes cancellation.

Expected behavior

Does not cancel dragging on scroll.

Actual behavior

Does cancel dragging on scroll toward top edge.

Steps to reproduce

  1. Open below "vertical list" example in Safari landscape mode.
  2. https://codesandbox.io/s/k260nyxq9v
  3. Scroll toward bottom edge, you'll find address bar is shrunk.
  4. Drag item toward top edge
  5. At some point of scrolling, Safari shows address bar.
  6. Dragging is cancelled.

Suggested solution?

Remove resize event listener, or make it optional.

@100terres 100terres added the bug Something isn't working label Mar 14, 2022
@100terres 100terres self-assigned this Mar 14, 2022
@robotic-forest
Copy link

@100terres any progress on this issue? Its currently making my app pretty janky for my users. Hope its receiving active attention here - I switched over from the main repo to this fork for that exact reason.
Let me know if there's anything I can do to help :)

@100terres
Copy link
Collaborator Author

Hi @robotic-forest 👋

Currently my proirity is to support react v18, but I'll go back to this issue as soon as possible 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants