Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap requires Popper.js #2

Closed
derlin opened this issue Jul 16, 2018 · 2 comments
Closed

Bootstrap requires Popper.js #2

derlin opened this issue Jul 16, 2018 · 2 comments
Assignees
@greyli
Labels
bug Something isn't working

Comments

@derlin
Copy link

derlin commented Jul 16, 2018

When using bootstrap.load_js(), the popper script is included after bootstrap, ending with

Bootstrap requires Popper.js

when using dropdowns, etc. A simple fix is to change the order of Markup in the last line of __init__.py:

# render popper before js
return Markup('%s\n%s\n%s\n' % (jquery, popper, js))
@greyli
Copy link
Member

greyli commented Jul 16, 2018

Thanks, I' ll fix it and release a new version late in the day.

@greyli greyli self-assigned this Jul 16, 2018
@greyli greyli added bug Something isn't working in process and removed in process labels Jul 16, 2018
@greyli
Copy link
Member

greyli commented Jul 16, 2018

Version 1.0.2 released. Thanks again.

@greyli greyli closed this as completed Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greyli greyli

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@derlin @greyli