Update dependencies #31
Conversation
- minimum php is 5.3.3 - swiftmailer/swiftmailer to 5.4.0 - jeremeamia/superclosure to 1.0.2 - phpunit/phpunit to 4.6.6 - symfony/filesystem to 2.6.7
|
Thanks for the PR! This looks good. I agree with your note about a new minor version (2.1.0). Could you update the README to make a note about the breaking changes, and that for reasons X and Y, you must use the 2.0.x versions of jobby? |
minor ones: - symfony/filesystem from 2.6 to 2.7 - symfony/yaml from 2.6 to 2.7 - phpunit/php-code-coverage from 2.0 to 2.1 and some libraries which changed their patch-version
|
You're welcome; and you are right, documentation is needed. I have added CHANGELOG-2.1.md and UPGRADE-2.1.md (this docu-style is inspired by Symfony). Do you think, this documentation is complete and understandable? |
|
I think the documentation is spot on. I will wait a few days for Jeremy's response. In any case, I will merge and do a new release in a few days. Thanks again. |
|
Hi, I just wanted to ask for the status. I have another jobby-feature-branch, feature/jobs-from-pdo, which I will create a Pull-Request for, as soon as this Pull-Request #31 is accepted. Maybe you want to include feature/jobs-from-pdo in jobby2.1.0, too. |
|
Ah, I was waiting on a test for #32 to merge both, but I think I will write it myself and then merge both. Hopefully today or tomorrow. |
I updated several dependencies to their latest versions. The reason behind, SuperClosure really needs to be updated. SuperClosure 1.* depends on nikic/php-parser v.0.9, which itself is outdated. I was not able to install jobby into my project, as other libraries, such as theseer/phpdox, require nikic/php-parser >= v.1.0.
I thought this to be a code point to require php5.3.3, as depending libraries require this version (phpunit, symfony/filesystem).
This change is dangerous, maybe jobby needs it's next minor-version. As SuperClosure changes the way, "scoped" closures are handled, jobby will not be BC-compatible. See changes in tests/Jobby/JobbyTest.php - as JobbyTest was not autoloadable from Jobby\BackgroundJob, I had to change the closures to be static-ones.