-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
energy impact ⚡️ #19
Comments
Looks like we're polling a remote endpoint on this line, which is likely the culprit for a high energy impact: https://github.com/HelloWorld017/atom-discord/blob/master/src/send-discord.js#L87 |
A package configuration option for the poll interval (currently set to 3 seconds) is probably the easiest/quickest way to provide a solution that works for everyone. |
Well, I won't target Anyways, being with 40 community packages which I can tell that most of them are doing some front-end stuff |
Oh the interval you're talking about shouldn't be like that and I can agree on that. I will make a pull request and see how it goes. |
Setting interval is already in settings (added at 4236d9a) |
That is still wrong @HelloWorld017 I'm making a PR right now to clarify things. |
I really appreciate your contribution! |
No problem, I'm just here to help some good ideas, glad that it is you to make it and not some guy who won't listen to his users |
@marclundgren I hope #20 will make your PC to feel better 😄 |
@marclundgren @HelloWorld017 Can one of you close this issue please? |
I just spent about an hour diagnosing my Atom's high energy consumption and narrowed it down to this package. Discord was not open when I ran these tests.
I've got about 40 community packages combined. The total energy consumption saved when I disabled this package was about 2700% more efficient with
atom-discord
disabled.:(
The text was updated successfully, but these errors were encountered: