Skip to content

Commit

Permalink
msm_fb: Set timeline threshold for command mode to 2
Browse files Browse the repository at this point in the history
For command mode panel, timeline threshold is 1 and we return
commit ioctl on DMA_P interrupt. This causes fps to drop
since sometimes overlay is kickoff just after vsync interrupt
causing DMA_P wait time more than 1 vsync period. Hence, increase
timeline to 2 and return commit ioctl on vsync interrupt.

CRs-fixed: 457153
CRs-fixed: 452269
Change-Id: Ic7385631fdeb25f269306d284c94fdf43cade3d1
Signed-off-by: Padmanabhan Komanduru <pkomandu@codeaurora.org>
Signed-off-by: Naseer Ahmed <naseer@codeaurora.org>
  • Loading branch information
naseer authored and hellsgod committed Aug 19, 2013
1 parent a3e55d9 commit f4d7915
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 9 deletions.
10 changes: 3 additions & 7 deletions drivers/video/msm/mdp4_overlay_dsi_cmd.c
Expand Up @@ -415,12 +415,8 @@ int mdp4_dsi_cmd_pipe_commit(int cndx, int wait)

mdp4_stat.overlay_commit[pipe->mixer_num]++;

if (wait) {
if (pipe->ov_blt_addr)
mdp4_dsi_cmd_wait4ov(0);
else
mdp4_dsi_cmd_wait4dmap(0);
}
if (wait)
mdp4_dsi_cmd_wait4vsync(0);

return cnt;
}
Expand Down Expand Up @@ -1231,7 +1227,7 @@ void mdp4_dsi_cmd_overlay(struct msm_fb_data_type *mfd)
}

mdp4_overlay_mdp_perf_upd(mfd, 1);
mdp4_dsi_cmd_pipe_commit(cndx, 1);
mdp4_dsi_cmd_pipe_commit(cndx, 0);
mdp4_overlay_mdp_perf_upd(mfd, 0);
mutex_unlock(&mfd->dma->ov_mutex);

Expand Down
3 changes: 1 addition & 2 deletions drivers/video/msm/msm_fb.c
Expand Up @@ -3738,8 +3738,7 @@ static int msmfb_handle_buf_sync_ioctl(struct msm_fb_data_type *mfd,
if (buf_sync->flags & MDP_BUF_SYNC_FLAG_WAIT) {
msm_fb_wait_for_fence(mfd);
}
if ((mfd->panel.type == MIPI_CMD_PANEL) ||
(mfd->panel.type == WRITEBACK_PANEL))
if (mfd->panel.type == WRITEBACK_PANEL)
threshold = 1;
else
threshold = 2;
Expand Down

0 comments on commit f4d7915

Please sign in to comment.