Snapshot tests always pass before --update is run

[pete-woods]

(version: 0.3.6)

When adding a new snapshot test, the tests always seem to pass if no snapshot has been created yet.

E.g. if I add a test case like this:

  - it: should do some stuff
    set:
      deployment:
        name: hello
    asserts:
      - matchSnapshot: {}

running helm unittest ... results in a pass.

So if I change something, e.g.:

  - it: should do some stuff
    set:
      deployment:
        name: goodbye
    asserts:
      - matchSnapshot: {}

the tests still pass.

It's only after I run with -u, and a snapshot is generated, that I can get a test failure.

It seems like a fairly serious bug, as you can get things into production thinking you've not changed your snapshots, but really you have.

Probably the match snapshot func should always fail if no snapshot is found.

[ryanvana]

An example of where this is a problem

{{- if .Values.feature.enabled --}}
apiVersion: keda.sh/v1alpha1
kind: TriggerAuthentication
metadata:
  name: {{ .Values.name }}
  namespace: {{ .Values.namespace }}
  labels:
    app: {{ .Values.name }}
    deploymentName: {{ .Values.name }}
spec:
  env: {{ toYaml .Values.env | nindent 4 }}
{{- end -}}

Changing the feature.enabled property will cause the snapshot to update.

[ryanvana]

Would you be open to accepting pull requests for this issue?