Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect difference on main branch from latest tag #649

Closed
ebuildy opened this issue May 18, 2024 · 2 comments
Closed

Detect difference on main branch from latest tag #649

ebuildy opened this issue May 18, 2024 · 2 comments

Comments

@ebuildy
Copy link

ebuildy commented May 18, 2024

Is this a request for help?:

FEATURE REQUEST

What happened:

When pushing on main branch, ct list-changed dont detect any change, this is normal behavior.

What you expected to happen:

I should see changes between commit and latest tag.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know:

Should copy the idea from https://github.com/helm/chart-releaser-action/blob/main/cr.sh#L273

@wzooff
Copy link

wzooff commented Jun 13, 2024

ct doesn't know how you've decided to tag your charts. If it's a mono repo, the latest tag is not always a tag for your specific chart, if you manage releases with release-please for example

The tool suggested by the link in issue expects to publish all charts under the same tag. It will not work for everyone.

But ct provides --since argument, so you can calculate on your side and specify sha that the latest tag points to.

I use --since=HEAD~1 to check only the latest commit when in a default repository branch.

@ebuildy
Copy link
Author

ebuildy commented Jun 13, 2024

ho I see, this is unopinioned !

@ebuildy ebuildy closed this as completed Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants